Getting reviews¶
Thorough code reviews are one of Mozilla’s ways of ensuring code quality. Every patch must be reviewed by the module owner of the code, or one of their designated peers.
To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
For example, the syntax to request review from a group should be:
Bug xxxx - explain what you are doing and why r?#group-name
or
Bug xxxx - explain what you are doing and why r?developer-nickname
Getting attention: If a reviewer doesn’t respond within a week, or so of the review request:
Contact the reviewer directly (either via e-mail or on Matrix).
Join developers on Mozilla’s Matrix server, and ask if anyone knows why a review may be delayed. Please link to the bug too.
If the review is still not addressed, mail the reviewer directly, asking if/when they’ll have time to review the patch, or might otherwise be able to review it.
For simple documentation changes, reviews are not required.
For more information about the review process, see the Code Review FAQ.
Review groups¶
Name |
Owns |
Members |
|---|---|---|
#anti-tracking |
||
#build or #firefox-build-system-reviewers |
The configure & build system |
|
#cookies |
||
#desktop-theme-reviewers |
User interface CSS |
|
#devtools-reviewers |
Firefox DevTools |
|
#dom-workers-and-storage-reviewers |
DOM Workers & Storage |
|
#fluent-reviewers |
Changes to Fluent (FTL) files (translation). |
|
#firefox-source-docs-reviewers |
Documentation files and its build |
|
#firefox-ux-team |
User experience (UX) |
|
#firefox-svg-reviewers |
SVG-related changes |
|
#frontend-codestyle-reviewers |
Changes to ESLint, Prettier or Stylelint configurations. |
|
#android-reviewers |
Changes to Fenix, Focus and Android Components. |
|
#geckoview-reviewers |
Changes to GeckoView |
|
#gfx-reviewers |
Changes to Graphics code |
|
#webgpu-reviewers |
Changes to WebGPU code |
|
#intermittent-reviewers |
Test manifest changes |
|
#layout-reviewers |
Layout changes. |
|
#linter-reviewers |
tools/lint/* |
|
#mac-reviewers |
Changes to Mac-specific code |
|
#mozbase |
Changes to Mozbase |
|
#mozbase-rust |
Changes to Mozbase in Rust |
|
#necko-reviewers |
Changes to network code (aka necko, aka netwerk) |
|
#nss-reviewers |
Changes to Network Security Services (NSS) |
|
#perftest-reviewers |
Perf Tests |
|
#permissions or #permissions-reviewers |
||
#places-reviewers |
||
#platform-i18n-reviewers |
Platform Internationalization |
|
#preferences-reviewers |
Firefox for Desktop Preferences (Options) user interface |
|
#remote-debugging-reviewers |
Remote Debugging UI & tools |
|
#search-reviewers |
Search Reviewers (search parts of Search and Address Bar) |
|
#spidermonkey-reviewers |
SpiderMonkey JS/Wasm Engine |
|
#static-analysis-reviewers |
Changes related to Static Analysis |
|
#style or #firefox-style-system-reviewers |
Firefox style system (servo, layout/style). |
|
#supply-chain-reviewers |
Changes to third-party audits and vendoring (cargo-vet, supply_chain). |
|
#webcompat-reviewers |
System addons maintained by the Web Compatibility team |
|
#webdriver-reviewers |
Marionette and geckodriver (including MozBase Rust), and Remote Protocol with WebDriver BiDi, and CDP. |
|
#webidl |
Changes related to WebIDL |
|
#xpcom-reviewers |
Changes related to XPCOM |
|
#media-playback-reviewers |
||
#cubeb-reviewers |
Changes related to cubeb, Gecko’s audio input/output library and associated projects (audioipc, cubeb-rs, rust cubeb backends) |
To create a new group, fill a new bug in Conduit::Administration. See bug 1613306 as example.